test: deflake test-fs-promises-watch-iterator #60060
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
commented
Sep 28, 2025
| for (const fileName of [...this.files]) { | ||
| await writeFile(this.filePath(fileName), Date.now() + fileName.repeat(1e4)); | ||
| } | ||
| await setTimeout(common.platformTimeout(100)); |
There was a problem hiding this comment.
If there was a reason for this I will add it back, but I don't see it.
lpinca
commented
Sep 28, 2025
Comment on lines
+37
to
+38
| // Do the write with a delay to ensure that the OS is ready to notify us. | ||
| await setTimeout(common.platformTimeout(100)); |
There was a problem hiding this comment.
The same is done in other fs.watch() tests, for example:
node/test/parallel/test-fs-watch-recursive-add-file.js
Lines 41 to 44 in c6316f9
There was a problem hiding this comment.
I think this deserves a TODO to investigate why this is occuring and whether or not this is a bug.
There was a problem hiding this comment.
There already an open issue (#52601) linked in the commit message.
addaleax
approved these changes
Sep 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60060 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01%
==========================================
Files 703 703
Lines 207826 207826
Branches 40030 40038 +8
==========================================
- Hits 183842 183826 -16
+ Misses 15973 15972 -1
- Partials 8011 8028 +17 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
gurgunday
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Add a delay before writing the files to ensure that the watcher receives the notifications. Fixes: nodejs#60051 Refs: nodejs#52601
lpinca
force-pushed
the
deflake/test-fs-promises-watch-iterator
branch
from
d3b5d31 to
dfdbb39
Compare
|
Rebased, this needs new approvals. |
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a delay before writing the files to ensure that the watcher receives the notifications.
Fixes: #60051
Refs: #52601